fix: asynchronously destroy items evicted on clearHistory navigation #847
Conversation
…troying them immediately. - finally destroy them on navigatedFrom event
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
| @@ -244,6 +250,7 @@ export class PageRouterOutlet { // tslint:disable-line:directive-class-suffix | |||
| this.locationStrategy._beginBackPageNavigation(); | |||
| this.locationStrategy.back(); | |||
| } | |||
| setTimeout(() => this.destroyQueuedCacheItems()); | |||
There was a problem hiding this comment.
Maybe that shouldn't be in navigatedFrom but in navigatingTo event handler?
|
Any update on that? |
|
Hi @buuhuu. |
|
Hello. I don't wanna bother you guys, but I just wanted to ask, is this going to be merged anytime soon? This would solve my issue where setting clearHistory to true makes the services not load properly and thus I get errors on the next page if I try to use the services. |
|
Can one of the admins verify this patch? |
|
@Ericky14 feel free to use my repo. Simply use the following reference in your package.json: Though this is not forked from master but using a detached HEAD from the 3.0.0 release tag. I have that running in our (almost live) app. |
| @@ -242,7 +248,10 @@ export class PageRouterOutlet { // tslint:disable-line:directive-class-suffix | |||
| // Add it to the new page | |||
| page.content = componentView; | |||
|
|
|||
| page.on("navigatedFrom", (<any>global).Zone.current.wrap((args: NavigatedData) => { | |||
| page.on(Page.navigatedToEvent, () => setTimeout(() => { | |||
There was a problem hiding this comment.
Heya, do we need the setTimeout here?
There was a problem hiding this comment.
Technically we don't BUT what I want to achieve is to push the actual execution to the end of the event loop so when the view tree to destroy is huge the main thread has time to actually do other things before the clean up happens.
|
run ci |
|
LGTM, will merge after green build 😄 |
|
We have that (almost) in production already ;) |
|
sdkwebpack |
sis0k0
changed the title
|
Still experiencing the same problem with v4.2. |
Fixes #829